Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21403#discussion_r198842091
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -161,33 +161,38 @@ case class Not(child: Expression)
true
""")
// scalastyle:on line.size.limit
-case class In(value: Expression, list: Seq[Expression]) extends Predicate {
+case class In(values: Seq[Expression], list: Seq[Expression]) extends
Predicate {
--- End diff --
+1 on `InValues`. Maybe call it `InSubquery`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
