Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3032#discussion_r19715279
  
    --- Diff: 
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
    @@ -30,13 +31,20 @@ private[spark] class FetchFailedException(
         bmAddress: BlockManagerId,
         shuffleId: Int,
         mapId: Int,
    -    reduceId: Int)
    -  extends Exception {
    +    reduceId: Int,
    +    message: String)
    +  extends Exception(message) {
    +
    +  def this(bmAddress: BlockManagerId, shuffleId: Int, mapId: Int, 
reduceId: Int, e: Throwable) {
    +    this(bmAddress, shuffleId, mapId, reduceId, e.getMessage)
    +    initCause(e)
    +  }
     
       override def getMessage: String =
    --- End diff --
    
    Having this override the getMessage means that the message parameter does 
not propagate correctly. We should probably get rid of this method here. Doing 
so means that the stages page does not show these stats, just the cause 
message, but the console and the job page show the "TaskEndReason", which 
includes the address as well as the exception itself. This looks pretty good 
from a usability perspective.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to