Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r199057309 --- Diff: R/pkg/R/DataFrame.R --- @@ -3905,6 +3905,18 @@ setMethod("rollup", groupedData(sgd) }) +isTypeAllowed <- function(x) { + if (is.character(x)) { + TRUE + } else if (is.list(x)) { --- End diff -- in R list could have a list too, not sure if we should recurse indefinitely ``` > a <- list(list(a = 1, b = 2)) > a [[1]] [[1]]$a [1] 1 [[1]]$b [1] 2 ```
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org