Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21321#discussion_r199091397 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala --- @@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid: String) extends Transforme require(dataType.isInstanceOf[NumericType] || --- End diff -- I couldn't do that because `NumericType` is an `AbstractDataType` and not a `DataType` so I couldn't use that method.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org