Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21667#discussion_r199095666
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
 ---
    @@ -152,6 +152,16 @@ trait FileFormat {
         }
       }
     
    +  /**
    +   * Returns whether this format supports the given [[DataType]] in 
read/write path.
    +   *
    +   * By default all data types are supported except 
[[CalendarIntervalType]] in write path.
    +   */
    +  def supportDataType(dataType: DataType, isReadPath: Boolean): Boolean = 
dataType match {
    --- End diff --
    
    Might be easier to write but it doesn't consider if we happened to have 
some more types on the other hand. It should better be explicit on what we 
support on the other hand.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to