Github user xueyumusic commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21575#discussion_r199143954
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -74,17 +75,17 @@ private[spark] class HeartbeatReceiver(sc: 
SparkContext, clock: Clock)
     
       // "spark.network.timeout" uses "seconds", while 
`spark.storage.blockManagerSlaveTimeoutMs` uses
       // "milliseconds"
    -  private val slaveTimeoutMs =
    -    sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs", "120s")
       private val executorTimeoutMs =
    -    sc.conf.getTimeAsSeconds("spark.network.timeout", 
s"${slaveTimeoutMs}ms") * 1000
    +    sc.conf.getTimeAsSeconds("spark.network.timeout",
    --- End diff --
    
    updated, please have a review, thank you @zsxwing @jiangxb1987 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to