Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21672#discussion_r199297784
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
---
@@ -106,7 +106,7 @@ private[spark] object SparkAppLauncher extends Logging {
val sparkSubmitExecutable = sparkHomeDir.resolve(Paths.get("bin",
"spark-submit"))
logInfo(s"Launching a spark app with arguments $appArguments and conf
$appConf")
val appArgsArray =
- if (appArguments.appArgs.length > 0)
Array(appArguments.appArgs.mkString(" "))
--- End diff --
Yes unless you pass a null... I updated my comment above ^^.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
