Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21514#discussion_r199317575
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -130,7 +130,13 @@ private[deploy] class Master(
         logInfo(s"Running Spark version ${org.apache.spark.SPARK_VERSION}")
         webUi = new MasterWebUI(this, webUiPort)
         webUi.bind()
    -    masterWebUiUrl = "http://"; + masterPublicAddress + ":" + 
webUi.boundPort
    +    val SSL_ENABLED = conf.getBoolean("spark.ssl.enabled", false)
    +    val uriScheme = "http://";
    +    if (SSL_ENABLED) {
    +      uriScheme = "https://";
    +    }
    +    masterWebUiUrl = uriScheme + masterPublicAddress + ":" + 
webUi.boundPort
    +    //masterWebUiUrl = "http://"; + masterPublicAddress + ":" + 
webUi.boundPort
    --- End diff --
    
    please remove this comment


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to