Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r199328450
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,16 @@ setMethod("rollup",
groupedData(sgd)
})
+isTypeAllowedForSqlHint <- function(x) {
+ if (is.character(x) | is.numeric(x)) {
+ TRUE
+ } else if (is.list(x)) {
+ all (sapply(x, (function (y) is.character(y) | is.numeric(y))))
--- End diff --
also, no space after `all` - it's really `all()`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
