[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

[pgandhi999]

GitHub user pgandhi999 opened a pull request:

    https://github.com/apache/spark/pull/21688

    [SPARK-21809] : Change Stage Page to use datatables to support sorting 
columns and searching

    Support column sort, pagination and search for Stage Page using jQuery 
DataTable and REST API. Before this commit, the Stage page generated a 
hard-coded HTML table that could not support search. Supporting search and sort 
(over all applications rather than the 20 entries in the current page) in any 
case will greatly improve the user experience.
    Created the stagespage-template.html for displaying application information 
in datables. Added REST api endpoint and javascript code to fetch data from the 
endpoint and display it on the data table.
    Because of the above change, certain functionalities in the page had to be 
modified to support the addition of datatables. For example, the toggle 
checkbox 'Select All' previously would add the checked fields as columns in the 
Task table and as rows in the Summary Metrics table, but after the change, only 
columns are added in the Task Table as it got tricky to add rows dynamically in 
the datatables.
    
    ## How was this patch tested?
    I have attached the screenshots of the Stage Page UI before and after the 
fix.
    **Before:**
    
    <img width="1419" alt="30564304-35991e1c-9c8a-11e7-850f-2ac7a347f600" 
src="https://user-images.githubusercontent.com/22228190/42137915-52054558-7d3a-11e8-8c85-433b2c94161d.png";>
    
    <img width="1435" alt="31360592-cbaa2bae-ad14-11e7-941d-95b4c7d14970" 
src="https://user-images.githubusercontent.com/22228190/42137928-79df500a-7d3a-11e8-9068-5630afe46ff3.png";>
    
    **After:**
    
    <img width="1432" alt="31360591-c5650ee4-ad14-11e7-9665-5a08d8f21830" 
src="https://user-images.githubusercontent.com/22228190/42137936-a3fb9f42-7d3a-11e8-8502-22b3897cbf64.png";>
    
    <img width="1388" alt="31360604-d266b6b0-ad14-11e7-94b5-dcc4bb5443f4" 
src="https://user-images.githubusercontent.com/22228190/42137970-0fabc58c-7d3b-11e8-95ad-383b1bd1f106.png";>
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pgandhi999/spark SPARK-21809-2.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21688
    
----
commit 5450258d7aef0772b9406c0ea5abb51096642ebb
Author: pgandhi <pgandhi@...>
Date:   2018-06-04T21:00:06Z

    [SPARK-21809] : Changing file executorspage-template.html and 
executorspage.js

commit dadc55f624e515b5a1771c48f300bfa466fb1754
Author: pgandhi <pgandhi@...>
Date:   2018-06-04T21:26:42Z

    [SPARK-21809] : Making changes in ui resources files

commit fc88decce9ac37ec3c639cda722464f26727e1be
Author: pgandhi <pgandhi@...>
Date:   2018-06-15T19:30:57Z

    [SPARK-21809] : Getting rquired data in api endpoints

commit 495caafc800f33ae09b2d4ff0eb8ce33e31d7cc9
Author: pgandhi <pgandhi@...>
Date:   2018-06-20T16:32:31Z

    [SPARK-21809] : Rendering the ui compatible with current version using 
datatables

commit c1d41d836f4d577e1188ca42e20abf9940f818ab
Author: pgandhi <pgandhi@...>
Date:   2018-06-22T22:10:15Z

    Working on Adding Server Side Sort Functionality

commit 567d22b07a7c434141b2d8e8bcc183f87b0d8d52
Author: pgandhi <pgandhi@...>
Date:   2018-06-25T21:39:47Z

    [SPARK-21809] : Implement Server Side Sorting Functionality

commit 649e95b86c7dd9c09173e11bcadfe9b6855b44a4
Author: pgandhi <pgandhi@...>
Date:   2018-06-27T18:14:18Z

    [SPARK-21809] : Implementing server side pagination and searching 
functionality

commit 590e93f814c93f4ccc30af50d9f28ae92bb708e3
Author: pgandhi <pgandhi@...>
Date:   2018-07-01T05:03:14Z

    [SPARK-21809] : Fixing Tests and task metric table

commit d79eb800bd8169cd063e1083d0444f755ffdb036
Author: pgandhi <pgandhi@...>
Date:   2018-07-01T19:18:59Z

    [SPARK-21809] : Refactoring Code and adding shufflereadmetrics data

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org