Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21682#discussion_r199390298
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -42,6 +42,14 @@ private[parquet] class ParquetFilters(pushDownDate: 
Boolean, pushDownStartWith:
       private val makeEq: PartialFunction[DataType, (String, Any) => 
FilterPredicate] = {
         case BooleanType =>
           (n: String, v: Any) => FilterApi.eq(booleanColumn(n), 
v.asInstanceOf[java.lang.Boolean])
    +    case ByteType =>
    --- End diff --
    
    Let us update the comment in the line 34. 
    ```
    Note: For now timestamp SQL type is not supported for pushing down, because 
the corresponding
          Parquet type can be Long or INT96. There is no context about Parquet 
type here.
    ``` 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to