Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21667#discussion_r199523308
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
---
@@ -152,6 +152,16 @@ trait FileFormat {
}
}
+ /**
+ * Returns whether this format supports the given [[DataType]] in
read/write path.
+ *
+ * By default all data types are supported except
[[CalendarIntervalType]] in write path.
+ */
+ def supportDataType(dataType: DataType, isReadPath: Boolean): Boolean =
dataType match {
--- End diff --
OK. I meant, leaving the default case `true`
```scala
def supportDataType(...): Boolean = dataType match {
case _ => true
}
```
and whitelist each type within each implementation, for example, in
`CSVFileFormat.scala`
```scala
def supportDataType(...) ...
case _: StringType | ... => true
case _ => false
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
