Github user ssuchter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199609501
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -265,6 +323,37 @@ private[spark] class KubernetesSuite extends
SparkFunSuite
assert(envVars("ENV2") === "VALUE2")
}
+ private def executeCommand(cmd: String*)(implicit podName: String):
String = {
+ val out = new ByteArrayOutputStream()
+ val watch = kubernetesTestComponents
+ .kubernetesClient
+ .pods()
+ .withName(podName)
+ .readingInput(System.in)
+ .writingOutput(out)
+ .writingError(System.err)
+ .withTTY()
+ .exec(cmd.toArray: _*)
+ // wait to get some result back
+ Thread.sleep(1000)
--- End diff --
This is a pretty quick timeout. Is there some way to have a longer timeout
but to return instantly if the watch command exits? E.g. some kind of "join"
method call on the watch instance that itself has a timeout?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
