Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21686#discussion_r199878616
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -3381,6 +3381,48 @@ object functions {
         from_json(e, dataType, options)
       }
     
    +  /**
    +   * (Scala-specific) Parses a column containing a JSON string into a 
`MapType` with `StringType`
    +   * as keys type, `StructType` or `ArrayType` of `StructType`s with the 
specified schema.
    +   * Returns `null`, in the case of an unparseable string.
    +   *
    +   * @param e a string column containing JSON data.
    +   * @param schema the schema to use when parsing the json string
    +   *
    +   * @group collection_funcs
    +   * @since 2.4.0
    +   */
    +  def from_json(e: Column, schema: Column): Column = {
    +    from_json(e, schema, Map.empty[String, String].asJava)
    +  }
    +
    +  /**
    +   * (Scala-specific) Parses a column containing a JSON string into a 
`MapType` with `StringType`
    --- End diff --
    
    I am not sure about this note at all. Why should it be Java or Scala 
specific?
    I will change it to `Java-specific` to have it in the same style as other 
comments.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to