Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21698#discussion_r200220771
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
@@ -82,15 +82,15 @@ private[scheduler] abstract class Stage(
private var _latestInfo: StageInfo = StageInfo.fromStage(this,
nextAttemptId)
/**
- * Set of stage attempt IDs that have failed with a FetchFailure. We
keep track of these
- * failures in order to avoid endless retries if a stage keeps failing
with a FetchFailure.
+ * Set of stage attempt IDs that have failed. We keep track of these
failures in order to avoid
+ * endless retries if a stage keeps failing.
* We keep track of each attempt ID that has failed to avoid recording
duplicate failures if
* multiple tasks from the same stage attempt fail (SPARK-5945).
*/
- val fetchFailedAttemptIds = new HashSet[Int]
+ val failedAttemptIds = new HashSet[Int]
--- End diff --
why rename it? we only increase it on fetch failure, don't we?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
