Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21405#discussion_r200244488
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -118,10 +119,10 @@ object JavaCode {
/**
* A trait representing a block of java code.
*/
-trait Block extends JavaCode {
+trait Block extends TreeNode[Block] with JavaCode {
import Block._
- // The expressions to be evaluated inside this block.
+ // All expressions to be evaluated inside this block and underlying
blocks.
def exprValues: Set[ExprValue]
--- End diff --
do we still need it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
