Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21677#discussion_r200246934
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
 ---
    @@ -427,16 +245,122 @@ object FilterPushdownBenchmark {
             }
           }
         }
    +  }
     
    -    // Pushdown for few distinct value case (use dictionary encoding)
    +  ignore("Pushdown for few distinct value case (use dictionary encoding)") 
{
         withTempPath { dir =>
           val numDistinctValues = 200
    -      val mid = numDistinctValues / 2
     
           withTempTable("orcTable", "patquetTable") {
             prepareStringDictTable(dir, numRows, numDistinctValues, width)
    -        runStringBenchmark(numRows, width, mid, "distinct string")
    +        runStringBenchmark(numRows, width, numDistinctValues / 2, 
"distinct string")
    +      }
    +    }
    +  }
    +
    +  ignore("Pushdown benchmark for StringStartsWith") {
    --- End diff --
    
    Yes


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to