Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21713#discussion_r200315553
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -166,6 +166,30 @@ object TypeCoercion {
         case (l, r) => None
       }
     
    +  private def mergeComplexTypes(
    +      t1: DataType,
    +      t2: DataType,
    --- End diff --
    
    Seems like the behavior will be changed if we reuse there, and the test 
[TypeCoercionSuite.scala#L397-L400](https://github.com/apache/spark/blob/bed6849dbf51e1981772cd353ce1a7ae4f0626e2/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala#L397-L400)
 fails.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to