Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21620#discussion_r200537707
  
    --- Diff: 
sql/core/src/test/resources/sql-tests/results/typeCoercion/native/arrayJoin.sql.out
 ---
    @@ -0,0 +1,90 @@
    +-- Automatically generated by SQLQueryTestSuite
    +-- Number of queries: 11
    +
    +
    +-- !query 0
    +SELECT array_join(array(true, false), ', ')
    +-- !query 0 schema
    +struct<array_join(array(true, false), , ):string>
    +-- !query 0 output
    +true, false
    +
    +
    +-- !query 1
    +SELECT array_join(array(2Y, 1Y), ', ')
    +-- !query 1 schema
    +struct<array_join(array(2, 1), , ):string>
    +-- !query 1 output
    +2, 1
    +
    +
    +-- !query 2
    +SELECT array_join(array(2S, 1S), ', ')
    +-- !query 2 schema
    +struct<array_join(array(2, 1), , ):string>
    +-- !query 2 output
    +2, 1
    +
    +
    +-- !query 3
    +SELECT array_join(array(2, 1), ', ')
    +-- !query 3 schema
    +struct<array_join(array(2, 1), , ):string>
    +-- !query 3 output
    +2, 1
    +
    +
    +-- !query 4
    +SELECT array_join(array(2L, 1L), ', ')
    +-- !query 4 schema
    +struct<array_join(array(2, 1), , ):string>
    +-- !query 4 output
    +2, 1
    +
    +
    +-- !query 5
    +SELECT array_join(array(9223372036854775809, 9223372036854775808), ', ')
    +-- !query 5 schema
    +struct<array_join(array(9223372036854775809, 9223372036854775808), , 
):string>
    +-- !query 5 output
    +9223372036854775809, 9223372036854775808
    +
    +
    +-- !query 6
    +SELECT array_join(array(2.0D, 1.0D), ', ')
    +-- !query 6 schema
    +struct<array_join(array(2.0, 1.0), , ):string>
    +-- !query 6 output
    +2.0, 1.0
    +
    +
    +-- !query 7
    +SELECT array_join(array(float(2.0), float(1.0)), ', ')
    +-- !query 7 schema
    +struct<array_join(array(CAST(2.0 AS FLOAT), CAST(1.0 AS FLOAT)), , 
):string>
    +-- !query 7 output
    +2.0, 1.0
    +
    +
    +-- !query 8
    +SELECT array_join(array(date '2016-03-14', date '2016-03-13'), ', ')
    +-- !query 8 schema
    +struct<array_join(array(DATE '2016-03-14', DATE '2016-03-13'), , ):string>
    +-- !query 8 output
    +2016-03-14, 2016-03-13
    +
    +
    +-- !query 9
    +SELECT array_join(array(timestamp '2016-11-15 20:54:00.000', timestamp 
'2016-11-12 20:54:00.000'), ', ')
    +-- !query 9 schema
    +struct<array_join(array(TIMESTAMP('2016-11-15 20:54:00.0'), 
TIMESTAMP('2016-11-12 20:54:00.0')), , ):string>
    --- End diff --
    
    Hm, yes, it will be. In general, if an expression has `children: 
Seq[Expression]` as its argument, the automatically generated column name will 
be long for now?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to