Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21146#discussion_r200596975
  
    --- Diff: dev/deps/spark-deps-hadoop-2.6 ---
    @@ -21,8 +21,6 @@ automaton-1.11-8.jar
     avro-1.7.7.jar
     avro-ipc-1.7.7.jar
     avro-mapred-1.7.7-hadoop2.jar
    -base64-2.3.8.jar
    -bcprov-jdk15on-1.58.jar
    --- End diff --
    
    if there's nothing else for bouncy castle then it's cleaner for classpaths 
if it goes, as for imports.
    
    looking at Hadoop, it it pulls in bcprov-jdk16, but only for testing. and 
with out any explicit calls on bouncy castle APIs that I can see. Presumably 
its registered as a crypto
    
    ```xml
         <dependency>
           <groupId>org.bouncycastle</groupId>
           <artifactId>bcprov-jdk16</artifactId>
           <version>1.46</version>
           <scope>test</scope>
         </dependency>
    ```
    
    If it is going, I should update this PR & JIRA name to make clear it is gone


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to