Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200837002
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -414,7 +414,16 @@ groupingSet
;
pivotClause
- : PIVOT '(' aggregates=namedExpressionSeq FOR pivotColumn=identifier
IN '(' pivotValues+=constant (',' pivotValues+=constant)* ')' ')'
+ : PIVOT '(' aggregates=namedExpressionSeq FOR pivotColumn IN '('
pivotValues+=pivotValue (',' pivotValues+=pivotValue)* ')' ')'
+ ;
+
+pivotColumn
+ : identifiers+=identifier
+ | '(' identifiers+=identifier (',' identifiers+=identifier)* ')'
--- End diff --
Are there any specific reasons to restrict the `pivotColumn` by
`identifier`? Are there any cases when expressions still don't supported
properly with your changes?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
