Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21659#discussion_r200869393
  
    --- Diff: python/docs/Makefile ---
    @@ -1,19 +1,44 @@
     # Makefile for Sphinx documentation
     #
     
    +ifndef SPHINXBUILD
    +ifndef SPHINXPYTHON
    +SPHINXBUILD = sphinx-build
    +endif
    +endif
    +
    +ifdef SPHINXBUILD
    +# User-friendly check for sphinx-build.
    +ifeq ($(shell which $(SPHINXBUILD) >/dev/null 2>&1; echo $$?), 1)
    +$(error The '$(SPHINXBUILD)' command was not found. Make sure you have 
Sphinx installed, then set the SPHINXBUILD environment variable to point to the 
full path of the '$(SPHINXBUILD)' executable. Alternatively you can add the 
directory with the executable to your PATH. If you don't have Sphinx installed, 
grab it from http://sphinx-doc.org/)
    +endif
    +else
    +# Note that there is an issue with Python version and Sphinx in PySpark 
documentation generation.
    +# Please remove this check below when this issue is fixed. See SPARK-24530 
for more details.
    +PYTHON_VERSION_CHECK = $(shell $(SPHINXPYTHON) -c 'import sys; 
print(sys.version_info < (3, 0, 0))')
    --- End diff --
    
    Can we fix the `SPHINXPYTHON` to python3 in release script 
`release-build.sh`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to