Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r19746366
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockId.scala ---
@@ -30,12 +30,13 @@ import org.apache.spark.annotation.DeveloperApi
* If your BlockId should be serializable, be sure to add it to the
BlockId.apply() method.
*/
@DeveloperApi
-sealed abstract class BlockId {
+sealed abstract class BlockId extends Serializable {
--- End diff --
Is there a reason to make this serializable ? There are subclasses which
are explicitly marked as non serializable
https://github.com/CodingCat/spark/blob/SPARK-3957/core/src/main/scala/org/apache/spark/storage/BlockId.scala#L89
@aarondav can probably comment ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
