Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21601#discussion_r201055350
--- Diff:
core/src/test/scala/org/apache/spark/input/WholeTextFileInputFormatSuite.scala
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.input
+
+import java.io.{DataOutputStream, File, FileOutputStream}
+
+import scala.collection.immutable.IndexedSeq
+
+import org.scalatest.BeforeAndAfterAll
+
+import org.apache.spark.{SparkConf, SparkContext, SparkFunSuite}
+import org.apache.spark.internal.Logging
+import org.apache.spark.util.Utils
+
+/**
+ * Tests the correctness of
+ * [[org.apache.spark.input.WholeTextFileInputFormat
WholeTextFileInputFormat]]. A temporary
+ * directory containing files is created as fake input which is deleted in
the end.
+ */
+class WholeTextFileInputFormatSuite extends SparkFunSuite with
BeforeAndAfterAll with Logging {
+ private var sc: SparkContext = _
+
+ override def beforeAll() {
+ super.beforeAll()
+ val conf = new SparkConf()
+ sc = new SparkContext("local", "test", conf)
+
+
sc.hadoopConfiguration.setLong("mapreduce.input.fileinputformat.split.minsize.per.node",
123456)
--- End diff --
would be nice to add comment here about 123456 value - ie it being larger
than maxSplitSize
Also can we move this down into the test itself
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
