Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18544#discussion_r201157378
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
    @@ -129,14 +129,14 @@ private[sql] class HiveSessionCatalog(
         Try(super.lookupFunction(funcName, children)) match {
           case Success(expr) => expr
           case Failure(error) =>
    -        if (functionRegistry.functionExists(funcName)) {
    -          // If the function actually exists in functionRegistry, it means 
that there is an
    -          // error when we create the Expression using the given children.
    +        if (super.functionExists(name)) {
    --- End diff --
    
    This should be replaced by `functionExists(name)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to