Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21652#discussion_r201360341
  
    --- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
 ---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.integrationtest
    +
    +import scala.collection.JavaConverters._
    +
    +import io.fabric8.kubernetes.api.model.{Pod, Secret, SecretBuilder}
    +import org.apache.commons.codec.binary.Base64
    +import org.apache.commons.io.output.ByteArrayOutputStream
    +import org.scalatest.concurrent.Eventually
    +
    +import org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite._
    +
    +private[spark] trait SecretsTestsSuite { k8sSuite: KubernetesSuite =>
    +
    +  import SecretsTestsSuite._
    +
    +  private def createTestSecret(): Secret = {
    +    val sb = new SecretBuilder()
    +    sb.withNewMetadata()
    +      .withName(ENV_SECRET_NAME)
    +      .endMetadata()
    +    val secUsername = 
Base64.encodeBase64String(ENV_SECRET_VALUE_1.getBytes())
    +    val secPassword = 
Base64.encodeBase64String(ENV_SECRET_VALUE_2.getBytes())
    +    val envSecretData = Map(ENV_SECRET_KEY_1 -> secUsername, 
ENV_SECRET_KEY_2 -> secPassword)
    +    sb.addToData(envSecretData.asJava)
    +    val envSecret = sb.build()
    +    val sec = kubernetesTestComponents
    +      .kubernetesClient
    +      .secrets()
    +      .createOrReplace(envSecret)
    +    sec
    --- End diff --
    
    yeah will fix.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to