Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21568
To me it is actually confusing to have the decimal one in there at all, by
defining a list of queries that are reused for different functional
testing. It is very easy to just ignore the subtle differences.
We are also risk over engineering this with only one use case.
On Tue, Jul 10, 2018 at 8:20 AM Wenchen Fan <notificati...@github.com>
wrote:
> We can deal with the decimal test file specially if that's the only use
> case. For now I'd say the join test is more important and let's finish it
> first.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/21568#issuecomment-403860889>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AATvPMjJPsZhXrOo_pbuxz-GwvKdds9lks5uFMYkgaJpZM4UoVQo>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
