Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21741#discussion_r201696558
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -387,6 +389,82 @@ class ParquetFilterSuite extends QueryTest with
ParquetTest with SharedSQLContex
}
}
+ test("filter pushdown - timestamp(TIMESTAMP_MILLIS)") {
+ val ts1 = Timestamp.valueOf("2018-06-14 08:28:53.123")
+ val ts2 = Timestamp.valueOf("2018-06-15 08:28:53.123")
+ val ts3 = Timestamp.valueOf("2018-06-16 08:28:53.123")
+ val ts4 = Timestamp.valueOf("2018-06-17 08:28:53.123")
+
+ val data = Seq(ts1, ts2, ts3, ts4)
+
+ withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
--- End diff --
This case is quite similar to the one below. Should we use a loop for
setting the key `SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key` to avoid duplicated
code.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
