Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21733#discussion_r201848371
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -825,6 +825,16 @@ object SQLConf {
         .intConf
         .createWithDefault(100)
     
    +  val ADVANCED_REMOVE_REDUNDANT_IN_STATEFUL_AGGREGATION =
    --- End diff --
    
    And the default value of this is `false` so end users will be aware of 
existence of this option, and have a chance to read the explanation before 
setting this option to `true`.
    
    We might elaborate a bit more on the config: tradeoff between reduced 
memory usage vs possible perf. hit and suggest running this in non-production 
before applying this to production. If we feel safer on elaborating more on 
this, I'm happy to update it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to