Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20611#discussion_r202359876
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1912,11 +1912,59 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
sql("LOAD DATA LOCAL INPATH '/non-exist-folder/*part*' INTO
TABLE load_t")
}.getMessage
assert(m.contains("LOAD DATA input path does not exist"))
+ }
+ }
+ }
- val m2 = intercept[AnalysisException] {
- sql(s"LOAD DATA LOCAL INPATH '$path*/*part*' INTO TABLE load_t")
+ test("Support wildcard character in folderlevel for LOAD DATA LOCAL
INPATH") {
+ withTempDir { dir =>
+ val path = dir.toURI.toString.stripSuffix("/")
+ val dirPath = dir.getAbsoluteFile
+ for (i <- 1 to 3) {
+ Files.write(s"$i", new File(dirPath, s"part-r-0000$i"),
StandardCharsets.UTF_8)
+ }
+ withTable("load_t_folder_wildcard") {
+ sql("CREATE TABLE load_t (a STRING)")
+ sql(s"LOAD DATA LOCAL INPATH '${
+ path.substring(0, path.length - 1)
+ .concat("*")
+ }/' INTO TABLE load_t")
+ checkAnswer(sql("SELECT * FROM load_t"), Seq(Row("1"), Row("2"),
Row("3")))
+ val m = intercept[AnalysisException] {
+ sql(s"LOAD DATA LOCAL INPATH '${
+ path.substring(0, path.length - 1).concat("_invalid_dir")
concat ("*")
+ }/' INTO TABLE load_t")
}.getMessage
- assert(m2.contains("LOAD DATA input path allows only filename
wildcard"))
+ assert(m.contains("LOAD DATA input path does not exist"))
+ }
+ }
+ }
--- End diff --
Still need a space here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
