Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r202418582
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -222,6 +225,14 @@ private[parquet] class ParquetFilters(pushDownDate:
Boolean, pushDownStartWith:
// See SPARK-20364.
def canMakeFilterOn(name: String): Boolean = nameToType.contains(name)
&& !name.contains(".")
+ // All DataTypes that support `makeEq` can provide better performance.
+ def shouldConvertInPredicate(name: String): Boolean = nameToType(name)
match {
--- End diff --
Let us keep it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
