Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21589#discussion_r202454060
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -2336,6 +2336,18 @@ class SparkContext(config: SparkConf) extends 
Logging {
        */
       def defaultMinPartitions: Int = math.min(defaultParallelism, 2)
     
    +  /**
    +   * Total number of CPU cores of all executors registered in the cluster 
at the moment.
    +   * The number reflects current status of the cluster and can change in 
the future.
    +   */
    --- End diff --
    
    > why @since 2.4.0 looks conventionally missed here.
    
    Just because other methods in the files don't have. It seems this file 
doesn't follow to common coding style. For example, methods don't end by `()`. 
See, `defaultMinPartitions` instead of `defaultMinPartitions()`.
    
    I will add `@since` and `@note`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to