Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-61584495
Question on approach here. There is a lot of code duplication between the
fine and coarse scheduler (as noted in comments in the coarse scheduler code).
I could continue this trend and duplicate the docker info code in both, or
perhaps pull it out into a ... ?
Being still new to the spark code, what approach would be more spark like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
