Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21770#discussion_r202534499
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -3758,7 +3758,10 @@ case class ArrayUnion(left: Expression, right: 
Expression) extends ArraySetLike
           } else {
             val arrayUnion = classOf[ArrayUnion].getName
             val et = ctx.addReferenceObj("elementTypeUnion", elementType)
    -        val order = ctx.addReferenceObj("orderingUnion", ordering)
    +        // Some data types (e.g., `BinaryType`) have anonymous classes for 
ordering and
    +        // `getCanonicalName` returns null in these classes. Therefore, we 
need to
    +        // explicitly set `className` here.
    --- End diff --
    
    nit: as we are adding this comment, shall we also mention that Janino works 
anyway, but JDK complains here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to