Github user dmateusp commented on a diff in the pull request:
https://github.com/apache/spark/pull/21740#discussion_r202542318
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -165,7 +183,7 @@ class MatrixFactorizationModel @Since("0.8.0") (
*/
@Since("1.1.0")
def recommendProducts(user: Int, num: Int): Array[Rating] =
--- End diff --
I'm new to the code base, I understand `Either` and `Option` isn't used a
lot in public APIs in Spark but shouldn't it be annotated that the functions
throws a certain type of exception (being more explicit with the Exception) ?
like `@throws(classOf[IllegalArgumentException])` ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
