Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202623270
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
v => s"""
| $v = new $samplerClass<UnsafeRow>($lowerBound, $upperBound,
false);
| $v.setSeed(${seed}L + partitionIndex);
- """.stripMargin.trim)
+ """.stripMargin.trim,
+ forceInline = true)
--- End diff --
Though this may cause problems leading to the 64KB limit issue. So if we
are not including the jdk support I'd be against this change...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
