Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202727503
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set the coresponding index of Boolean var when the task killed by
other attempt tasks,
// this happened while we set the `spark.speculation` to true. The task
killed by others
// should not resubmit while executor lost.
- private val killedByOtherAttempt: Array[Boolean] = new
Array[Boolean](numTasks)
+ private val killedByOtherAttempt = new HashSet[Long]
--- End diff --
I'm not proposing to expand the logInfo in L735 in this PR, I'm just
concern about whether it's convenient enough for me to add extra logs to debug
a potential issue. Since there is another way to achieve the same effect, I'm
okay with using hashSet here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
