Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3082#discussion_r19788132
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -77,9 +76,14 @@ private[spark] class ExecutorAllocationManager(sc:
SparkContext) extends Logging
"spark.dynamicAllocation.sustainedSchedulerBacklogTimeout",
schedulerBacklogTimeout)
// How long an executor must be idle for before it is removed
- private val removeThresholdSeconds = conf.getLong(
+ private val executorIdleTimeout = conf.getLong(
"spark.dynamicAllocation.executorIdleTimeout", 600)
+ // Whether we are testing this class. This should only be used
internally.
+ private val testing = conf.getBoolean("spark.dynamicAllocation.testing",
false)
--- End diff --
"spark.test.dynamicAllocation" might be a name more in line with other
test-only properties. Also please add some documentation or name that indicates
what it means to be testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
