Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21764#discussion_r202762054
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -127,6 +127,14 @@ object SQLConf {
         }
       }
     
    +  val OPTIMIZER_EXCLUDED_RULES = 
buildConf("spark.sql.optimizer.excludedRules")
    +    .doc("Configures a list of rules to be disabled in the optimizer, in 
which the rules are " +
    +      "specified by their rule names and separated by comma. It is not 
guaranteed that all the " +
    +      "rules in this configuration will eventually be excluded, as some 
rules are necessary " +
    --- End diff --
    
    Nice suggestion! @gatorsmile's other suggestion was to introduce a 
blacklist, in which case this enumeration of rules that cannot be excluded can 
be made possible. I can do a warning as well.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to