Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105805
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25 +29,27 @@ import org.scalatest.time.{Minutes, Seconds, Span}
import scala.collection.JavaConverters._
import org.apache.spark.SparkFunSuite
+import org.apache.spark.deploy.k8s.integrationtest.TestConfig._
import
org.apache.spark.deploy.k8s.integrationtest.backend.{IntegrationTestBackend,
IntegrationTestBackendFactory}
-import org.apache.spark.deploy.k8s.integrationtest.config._
-import org.apache.spark.launcher.SparkLauncher
private[spark] class KubernetesSuite extends SparkFunSuite
- with BeforeAndAfterAll with BeforeAndAfter {
+ with BeforeAndAfterAll with BeforeAndAfter with BasicTestsSuite with
SecretsTestsSuite
+ with PythonTestsSuite {
--- End diff --
This seems a bit cumbersome but is advantageous should we add a flag in our
PRB for triggering just base tests, + python, +r, and for the Kerberos
integration tests (which are quite sizeable) + Kerberos. I like the decision to
separate tests. I think it is appropriate.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
