Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20949#discussion_r203227873
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -625,6 +625,7 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
* enclosed in quotes. Default is to only escape values containing a
quote character.</li>
* <li>`header` (default `false`): writes the names of columns as the
first line.</li>
* <li>`nullValue` (default empty string): sets the string
representation of a null value.</li>
+ * <li>`encoding` (default `UTF-8`): encoding to use when saving to
file.</li>
--- End diff --
I think we should match the doc with JSON's
https://github.com/apache/spark/blob/6ea582e36ab0a2e4e01340f6fc8cfb8d493d567d/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L525-L526
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
