Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21710#discussion_r203229733
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -1415,6 +1415,13 @@ setGeneric("spark.freqItemsets", function(object) { 
standardGeneric("spark.freqI
     #' @rdname spark.fpGrowth
     setGeneric("spark.associationRules", function(object) { 
standardGeneric("spark.associationRules") })
     
    +#' @rdname spark.prefixSpan
    +setGeneric("spark.prefixSpan", function(...) { 
standardGeneric("spark.prefixSpan") })
    +
    +#' @rdname spark.prefixSpan
    --- End diff --
    
    @viirya Thanks for your review. 
    Do you mean to use ```findFrequentSequentialPatterns``` instead of 
```spark.findFrequentSequentialPatterns```? I have a question about when we 
need to add ```spark``` in front of the method name. In FPGrowth, some methods 
have ```spark.```, e.g.  ```spark.freqItemsets```, 
```spark.associationRules```. Some methods don't have ```spark.```, e.g. 
```predict``` and ```write.ml``` . 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to