Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21102#discussion_r203299689
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala ---
@@ -114,6 +118,21 @@ class OpenHashSet[@specialized(Long, Int) T: ClassTag](
rehashIfNeeded(k, grow, move)
}
+ /**
+ * Remove an element from the set. If an element does not exists in the
set, nothing is done.
+ */
+ def remove(k: T): Unit = {
--- End diff --
Maybe we should not add `remove` method unless we can add it by a simple
way. This is used in many places and this might affect their performance. How
about using other implementation?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
