Github user industrial-sloth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3093#discussion_r19824974
  
    --- Diff: 
core/src/main/scala/org/apache/spark/input/FixedLengthBinaryRecordReader.scala 
---
    @@ -115,7 +115,7 @@ private[spark] class FixedLengthBinaryRecordReader
         if (currentPosition < splitEnd) {
           // setup a buffer to store the record
           val buffer = recordValue.getBytes
    -      fileInputStream.read(buffer, 0, recordLength)
    +      fileInputStream.readFully(buffer)
    --- End diff --
    
    yep, but readFully will either block until the full number of bytes is 
available, or throw an error:
    
http://docs.oracle.com/javase/6/docs/api/java/io/DataInput.html#readFully(byte[])


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to