Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203561847
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -115,7 +116,7 @@ private[kafka010] class KafkaOffsetReader(
def fetchTopicPartitions(): Set[TopicPartition] = runUninterruptibly {
assert(Thread.currentThread().isInstanceOf[UninterruptibleThread])
// Poll to get the latest assigned partitions
- consumer.poll(0)
+ consumer.poll(JDuration.ofMillis(0))
--- End diff --
That's a good point. However, supporting all these versions are pretty
cheap for Spark right now. Spark is using only APIs in 0.10. In addition, if
the Kafka client version we pick up here has some critical issue, the user can
just switch to an old version.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
