Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21774#discussion_r203805849
  
    --- Diff: 
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroFunctionsSuite.scala 
---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.avro
    +
    +import org.apache.avro.Schema
    +
    +import org.apache.spark.sql.QueryTest
    +import org.apache.spark.sql.functions.struct
    +import org.apache.spark.sql.test.SharedSQLContext
    +
    +class AvroFunctionsSuite extends QueryTest with SharedSQLContext {
    +  import testImplicits._
    +
    +  test("roundtrip in to_avro and from_avro - int and string") {
    +    val df = spark.range(10).select('id, 'id.cast("string").as("str"))
    +
    +    val avroDF = df.select(to_avro('id).as("a"), to_avro('str).as("b"))
    +    val avroTypeLong = new Schema.Parser().parse(
    +      s"""
    +         |{
    +         |  "type": "long",
    --- End diff --
    
    the test name says int and string?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to