Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21804#discussion_r203947449
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
    @@ -208,8 +208,9 @@ class FeatureHasher(@Since("2.3.0") override val uid: 
String) extends Transforme
           require(dataType.isInstanceOf[NumericType] ||
             dataType.isInstanceOf[StringType] ||
             dataType.isInstanceOf[BooleanType],
    -        s"FeatureHasher requires columns to be of NumericType, BooleanType 
or StringType. " +
    -          s"Column $fieldName was $dataType")
    +        s"FeatureHasher requires columns to be of 
${NumericType.simpleString}, " +
    --- End diff --
    
    Let us change all?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to