[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol “||” of the �...

[httfighter]

GitHub user httfighter opened a pull request:

    https://github.com/apache/spark/pull/21826

    [SPARK-24872] Remove the symbol “||” of the “OR” operation

    ## What changes were proposed in this pull request?
    “||” will perform the function of STRING concat, and it is also the 
symbol of the "OR" operation.
    
    When I want use "||" as "OR" operation, I find that it perform the function 
of STRING concat，
    
      spark-sql> explain extended select * from aa where id==1 || id==2;
    
       == Parsed Logical Plan ==
        'Project [*]
         +- 'Filter (('id = concat(1, 'id)) = 2)
          +- 'UnresolvedRelation `aa`
    
       spark-sql> select "abc" || "DFF" ;
    
       And the result is "abcDFF".
    
    In predicates.scala, "||" is the symbol of "Or" operation. Could we remove 
it?
    
    ## How was this patch tested?
    
    We can test this patch  with unit tests.
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/httfighter/spark SPARK-24872

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21826
    
----
commit fb98029c451023789a2c7fa0e758c6c8790bbaea
Author: 韩田田00222924 <han.tiantian@...>
Date:   2018-07-20T09:19:54Z

    SPARK-24872 Remove the symbol “||” of the “OR” operation

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org