Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21474#discussion_r204021872
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -429,7 +429,11 @@ package object config {
             "external shuffle service, this feature can only be worked when 
external shuffle" +
             "service is newer than Spark 2.2.")
           .bytesConf(ByteUnit.BYTE)
    -      .createWithDefault(Long.MaxValue)
    --- End diff --
    
    I think the original purpose to set to `Long.MaxValue` is to avoid using 
this configuration by default, user should set to a proper size to enable this 
feature. But anyway I think the current change is also fine.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to