Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21732#discussion_r204085770
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
    @@ -183,6 +184,43 @@ case class OptionBooleanAggregator(colName: String)
       def OptionalBoolEncoder: Encoder[Option[Boolean]] = ExpressionEncoder()
     }
     
    +case class OptionBooleanIntAggregator(colName: String)
    +    extends Aggregator[Row, Option[(Boolean, Int)], Option[(Boolean, 
Int)]] {
    --- End diff --
    
    Yes. For non top level, `[Option[Product]` is same as `Product`. The 
difference is additional `WrapOption` and `UnwrapOption` around expressions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to